HADOOP-18718. Fix several maven build warnings#5592
Merged
ayushtkn merged 2 commits intoapache:trunkfrom Jun 11, 2023
Merged
Conversation
dongjoon-hyun
changed the title
Contributor
|
looks good. worried that a move to spotbugs may have surprises, but it is only in 1 module and that already has a spotbugs by the look of things |
Member
|
Should be good, if the build doesn't complain. The findbug thing looks like a leftover to me. We don't run neither setup findbugs now in our jenkins job, we just run spotbugs |
Member
Author
|
Ya, I thought like that. Thank you, @steveloughran and @ayushtkn . |
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
Thank you, @ayushtkn . |
Member
|
Lets wait for Steve, if he is convinced. @dongjoon-hyun would require a PR to branch-3, as well, this doesn't cherry-pick directly over there |
Member
Author
|
BTW, the current CI seems to complain for something. Let me check more while I'm here. |
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
lgtm. do also think that we need to make sure that all surefile/failsafe uses print stack traces
Member
|
@dongjoon-hyun you marked this as draft, any further pointers, it was looking good enough to me atleast to merge |
Member
Author
|
Sorry for the delay, @ayushtkn . I converted it back. |
Contributor
|
hey, carry on without me. I'm too distracted to review anything. |
ayushtkn
reviewed
Jun 5, 2023
hadoop-project-dist/pom.xml
Outdated
| <charset>${maven.compile.encoding}</charset> | ||
| <reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory> | ||
| <destDir>${project.build.directory}/api</destDir> | ||
| <outputDirectory>${project.build.directory}/api</outputDirectory> |
Member
There was a problem hiding this comment.
here both are defined
https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html
Is there any behaviour change here? Both have different default values as well
cc. @GauthamBanasandra I think you were around this area, does it look good to you?
Member
Author
There was a problem hiding this comment.
The previous destDir was used for API directory and was the alias of outputDirectory.
Member
Author
There was a problem hiding this comment.
Shall we skip this line simply? I can revert two changes of this file to the original code.
Member
There was a problem hiding this comment.
I would yes, lets not do it, similar change is there in pom.xml
So, we can go ahead without this destDir -> outputDirectory change
Member
There was a problem hiding this comment.
Makes sense. Changing to outputDirectory would be redundant.
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
I updated the code and PR description by removing |
|
💔 -1 overall
This message was automatically generated. |
dongjoon-hyun
commented
Jun 7, 2023
dongjoon-hyun
force-pushed
the
HADOOP-18718-2
branch
from
290f339 to
c5ef569
Compare
|
💔 -1 overall
This message was automatically generated. |
GauthamBanasandra
approved these changes
Jun 8, 2023
Member
Author
|
Thank you, @GauthamBanasandra . |
ayushtkn
reviewed
Jun 9, 2023
| <copy file="src/main/resources/hdfs-rbf-default.xml" todir="src/site/resources"/> | ||
| <copy file="src/main/xsl/configuration.xsl" todir="src/site/resources"/> | ||
| </tasks> | ||
| </task> |
Member
There was a problem hiding this comment.
Was supposed to use target, right?
From the description
Use target instead of tasks.
Other places you moved tasks -> target only. Any specific reason here?
Member
Author
There was a problem hiding this comment.
My bad. You are right. I fixed it.
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
Thank you so much, @ayushtkn , @steveloughran , @GauthamBanasandra . |
asfgit
pushed a commit
that referenced
this pull request
Jun 12, 2023
…y Dongjoon Hyun. Reviewed-by: Gautham B A <gautham.bangalore@gmail.com> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org> (cherry picked from commit fb16e00) Conflicts: hadoop-tools/hadoop-federation-balance/pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR aims to fix the following build warnings which are a subset of the full warnings on Maven 3.9.1.
cyclonedx-maven-pluginversion is added.Use spotbugs-maven-plugin instead of findbugs-maven-plugin, removefindbug-maven-plugin.targetinstead oftasks.systemPropertyVariablesinstead ofsystemProperties.How was this patch tested?
Pass the CI and do the manual tests.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?